Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request pool manager options #1324

Merged

Conversation

JamesAPetts
Copy link
Member

Cornerstone imageLoaders registered to cornerstone can take options which may specific to the loader themselves.

This PR adds an argument to the request pool manager to pass options down options to its managed cornerstone.loadImage and cornerstone.loadAndCacheImage calls.

These options are merged with the default options request pool manager provides.

Copy link
Member

@swederik swederik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Options shouldn't overwrite priority and type, otherwise it's fine.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1324 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
- Coverage   18.94%   18.94%   -0.01%     
==========================================
  Files         286      286              
  Lines        8671     8672       +1     
  Branches     1486     1486              
==========================================
  Hits         1643     1643              
- Misses       5815     5816       +1     
  Partials     1213     1213              
Impacted Files Coverage Δ
src/requestPool/requestPoolManager.js 21.25% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf45a66...5bfc917. Read the comment docs.

@JamesAPetts JamesAPetts merged commit 18bfdf1 into cornerstonejs:master Nov 5, 2020
@dannyrb
Copy link
Member

dannyrb commented Nov 5, 2020

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants