Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid completed event when outside image #1256

Conversation

igoroctaviano
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #1256 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
- Coverage   18.97%   18.96%   -0.01%     
==========================================
  Files         286      286              
  Lines        8629     8632       +3     
  Branches     1471     1472       +1     
==========================================
  Hits         1637     1637              
- Misses       5790     5792       +2     
- Partials     1202     1203       +1     
Impacted Files Coverage Δ
...ispatchers/mouseEventHandlers/addNewMeasurement.js 5.55% <0.00%> (-0.70%) ⬇️
src/manipulators/moveNewHandle.js 5.47% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa54b30...fd70e60. Read the comment docs.

@dannyrb dannyrb merged commit c9e6fa3 into cornerstonejs:master Jun 30, 2020
@dannyrb
Copy link
Member

dannyrb commented Jun 30, 2020

🎉 This PR is included in version 4.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants