Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: length tool throws error when measured value "length" is undefined #1189

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

dannyrb
Copy link
Member

@dannyrb dannyrb commented Mar 13, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #1189 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   18.83%   18.82%   -0.02%     
==========================================
  Files         284      284              
  Lines        8510     8516       +6     
  Branches     1451     1453       +2     
==========================================
  Hits         1603     1603              
- Misses       5722     5726       +4     
- Partials     1185     1187       +2     
Impacted Files Coverage Δ
src/tools/annotation/LengthTool.js 36.61% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70b894...c926f59. Read the comment docs.

@dannyrb dannyrb merged commit 9a71b62 into master Mar 13, 2020
@dannyrb
Copy link
Member Author

dannyrb commented Mar 13, 2020

🎉 This PR is included in version 4.12.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant