-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1176 Pan and Zoom issue with segmentation on image with non-square pixels #1183
Conversation
Sync origin repo with new commits
… with non-square pixels
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
=========================================
Coverage ? 18.83%
=========================================
Files ? 284
Lines ? 8510
Branches ? 1451
=========================================
Hits ? 1603
Misses ? 5722
Partials ? 1185
Continue to review full report at Codecov.
|
Hey @MickeyMiao7 , thanks for the PR! This certainly looks like the right thing to do, and we get the same result as before on the square-images in the demo, so that's great. Have you tried this new version with your non-square pixel examples? |
Hey @JamesAPetts, yes the new version has solved the problem in non-square pixel examples. I build the You can see the problem has been solved from the following sandbox link: |
Thanks for swift reply and the live demo! This looks good to me. |
@all-contributors, please add @MickeyMiao7 for this great contribution! |
🎉 This PR is included in version 4.12.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors, please add @MickeyMiao7 for this awesome code |
Apparently the bot is not as appreciative as we are haha. |
Bug fix0
#1176
The segmentation boundary and semi-transparent infill undergo the same same translation, providing an accurate view of which pixels have been highlighted.
no