Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop throwing errors when calling removeToolState if toolData or… #1181

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

swederik
Copy link
Member

… toolData.data do not exist

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    It prevents errors if removeToolState is called when no toolData is present.

  • What is the current behavior? (You can also link to an open issue here)
    An error will be thrown when toolData.data is accessed, but toolData is undefined.

  • What is the new behavior (if this is a feature change)?
    It will exit early, avoiding the issue.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #1181 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   18.85%   18.85%   -0.01%     
==========================================
  Files         284      284              
  Lines        8500     8502       +2     
  Branches     1448     1449       +1     
==========================================
  Hits         1603     1603              
- Misses       5715     5716       +1     
- Partials     1182     1183       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e430ba...2d99c7f. Read the comment docs.

@dannyrb dannyrb self-requested a review February 19, 2020 13:24
Copy link
Member

@dannyrb dannyrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Applied a small update to make the build pass (unrelated to your changes)

@dannyrb dannyrb merged commit 1682fa8 into master Feb 20, 2020
@dannyrb
Copy link
Member

dannyrb commented Feb 20, 2020

🎉 This PR is included in version 4.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swederik swederik deleted the fix/removeToolState branch September 15, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants