fix: OverlayTool now considers overlay initial position #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @fexman |
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
=======================================
Coverage 18.86% 18.86%
=======================================
Files 284 284
Lines 8498 8498
Branches 1446 1446
=======================================
Hits 1603 1603
Misses 5715 5715
Partials 1180 1180
Continue to review full report at Codecov.
|
|
Maybe. Should I create another PR and add this? |
|
🎉 This PR is included in version 4.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Updated here: 4e430ba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
The initial position for DICOM overlays is now considered in OverlayTool.
What is the current behavior? (You can also link to an open issue here)
The origin of DICOM overlays from the overlayPlaneModule was fixed to 0,0.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: