Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event details to arrow tool getText callback #1131

Merged

Conversation

igoroctaviano
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature.

  • What is the current behavior? (You can also link to an open issue here)
    Currently we cannot access event details inside getTextCallback of arrow annotation tool.

  • What is the new behavior (if this is a feature change)?
    Now we can access event details inside getTextCallback of arrow annotation tool.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking change.

  • Other information:

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   18.97%   18.97%           
=======================================
  Files         282      282           
  Lines        8404     8404           
  Branches     1422     1422           
=======================================
  Hits         1595     1595           
  Misses       5653     5653           
  Partials     1156     1156
Impacted Files Coverage Δ
src/tools/annotation/ArrowAnnotateTool.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992c7c3...ae2314f. Read the comment docs.

@dannyrb dannyrb merged commit 24de8e4 into cornerstonejs:master Nov 20, 2019
@dannyrb
Copy link
Member

dannyrb commented Nov 20, 2019

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants