fix(getOrientationString): Add additional logic to handle equal vector component edge case #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging upstream
…r component edge case Fixes view angle vectors at 45 degrees
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
- Coverage 19.01% 18.98% -0.03%
==========================================
Files 282 282
Lines 8390 8403 +13
Branches 1419 1422 +3
==========================================
Hits 1595 1595
- Misses 5642 5652 +10
- Partials 1153 1156 +3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 4.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
If two of the vector components are the largest, but equal, nothing is returned in the
getOrientationStringfunctionWhat is the new behavior (if this is a feature change)?
Now returns the expected values, taking the order priority of X,Y,Z
example: input vector
[0.5, -.777, -.777]will be AFLDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: