Feature: add orientation markers tool #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=========================================
Coverage ? 17.83%
=========================================
Files ? 274
Lines ? 8428
Branches ? 1420
=========================================
Hits ? 1503
Misses ? 5759
Partials ? 1166
Continue to review full report at Codecov.
|
|
@frolic06 is this ready for review? |
|
Yes |
|
@dannyrb did you have to review this PR ? |
dannyrb
requested changes
Oct 7, 2019
There was a problem hiding this comment.
- Thanks for creating an example page
- The new tool's implementation looks good 👍
- A couple of small comments that need to be addressed before merge.
- It would be nice if you could add this to our netlify example as an "overlay" tool, and give the example images any meta they may need to render orientations markers.
|
Thanks for your hard work on this, @frolic06! ^_^ |
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
No
What is the new behavior (if this is a feature change)?
It adds a tool called OrientationMarkersTool, which displays orientation markers like in version 2.X
Some code:
const orientationMarkers = cornerstoneTools['OrientationMarkersTool'];cornerstoneTools.addToolForElement(element, orientationMarkers);cornerstoneTools.setToolActiveForElement(this.element, 'OrientationMarkers', {});Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: