Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(src/util/clip.js): fix lib.js import part of clip error #1085

Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix(src/util/clip.js): fix lib.js import part of clip error #1085

merged 1 commit into from
Sep 27, 2019

Conversation

xingbofeng
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • add part of export for clip.js, because lib.js import function clip by part import

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #1085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1085   +/-   ##
======================================
  Coverage    17.3%   17.3%           
======================================
  Files         272     272           
  Lines        8309    8309           
  Branches     1406    1406           
======================================
  Hits         1438    1438           
  Misses       5712    5712           
  Partials     1159    1159
Impacted Files Coverage Δ
src/util/clip.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b50c98...b7ca650. Read the comment docs.

@dannyrb
Copy link
Member

dannyrb commented Sep 27, 2019

Ah. Okay. So lib pulls this in with named export (undefined). This resolves that issue.

Thanks for the PR!

@dannyrb dannyrb merged commit 41e0f4f into cornerstonejs:master Sep 27, 2019
@dannyrb
Copy link
Member

dannyrb commented Sep 27, 2019

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants