Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename line_trace() to trace() #5

Open
tancheng opened this issue Jul 23, 2019 · 2 comments
Open

Rename line_trace() to trace() #5

tancheng opened this issue Jul 23, 2019 · 2 comments

Comments

@tancheng
Copy link
Contributor

Now all the modules come with line_trace() to provide trace information. We might want to change it to trace() to make it conformed with construct() and place().

@cbatten
Copy link

cbatten commented Jul 24, 2019

I like the idea of calling in trace(). Can you see what Shunning thinks?

@cbatten
Copy link

cbatten commented Jul 24, 2019

@jsn1993 what do you think about renaming line_trace() to just be trace()? That way construct(), place(), and trace() are all verbs ... in general classes should be nouns and methods should be verbs ... so my vote would be to use trace().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants