ivy runtime error

[Corfus]

Skyhook works perfect with the actual default angular compiler, but when you change the compiler to ivy, you get this runtime error.

It seems to be a problem with the directives and ivy.

[cormacrelf]

angular/angular#25813

[cormacrelf]

Ivy is meant to be backwards compatible, although I am sure there must be caveats, as nothing in JavaScript is actually that easy. In any case, I'm going to assume Ivy-related bugs are on Ivy's side until convinced otherwise, and do close to zero investigation. You can leave it open in case anyone else comes across it.

[ErynManela]

the injection context is a breaking change. however if someone wants to use your existing build they run the basic postinstall script described here on a project that depends on angular-skyhook, it should work:
https://next.angular.io/guide/migration-ngcc

"postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points"
this should do all the conversion for anyone using the library.

That said, when you do that the other postinstall script they mention, the for use with nguniversal,
"postinstall": "ngcc --properties main --create-ivy-entry-points"
fails if using @angular-skyhook/dnd-multi-backend due to angular/angular#33697

This and a number of other number of breaking changes ng update will fix for you and leave the library in a state that is still backwards compatible.

[cormacrelf]

This is great, thank you.

[ErynManela]

Once you pull in the dnd-multi-backend v5 update the ngcc error should go away because the rollups are better formatted. That doesn't make it natively ivy compatible, but it will make it useable. When is that branch going to be ready? Could you make a beta release off that branch for testing purposes? It would be very helpful.

[cormacrelf]

1.4.0-rc.0

[cormacrelf]

#507

[Corfus]

I found the problem with ivy.
In Ivy you have to inherit from another directive.
So your abstract class DndDirective doesn't work with ivy, if you adapt it to a real Directive it should be ivy compatible, see here:

https://next.angular.io/guide/ivy-compatibility-examples#undecorated-classes

In my fork it is fixed: https://github.com/Corfus/-angular-skyhook-ivy/tree/cdb/ivy-compatibility-fix

[cormacrelf]

Is that all that needed to be done?

In any case, can you make a PR? A fork is cool, but a PR actually helps land the fix.

[Corfus]

Yes with this adaptions it works without distinctions with ivy, too.

I made the PR. #532

[AlbaLopez]

@cormacrelf when do you think it will be merged?

[cormacrelf]

I think I’ll wait about 2 years, during which time I will get to some of the little things I’ve always wanted to do, like cultivate a tasteful indoor-plant aesthetic, whittle a log into the shape of a realistic Christmas ham, and train as a spider milker at the local zoo.

[AlbaLopez]

I think I’ll wait about 2 years, during which time I will get to some of the little things I’ve always wanted to do, like cultivate a tasteful indoor-plant aesthetic, whittle a log into the shape of a realistic Christmas ham, and train as a spider milker at the local zoo.

A somewhat exaggerated answer to a question without bad intention.

Good luck and follow your dreams.

[cormacrelf]

I had hoped that merging the PR immediately would let me joke about it, but apparently no. Back to being a maintenance robot it is.

[initplatform]

Did I miss the release?

[ErynManela]

Yay angular 9 is out! finally! I'm sticking with ViewEngine for a few months before switching to Ivy, but following this thread to see how much spider milk @cormacrelf has made. I'd like to see a picture of the ham log, too.

[palpatine1991]

Any update to this? ngcc advice from @aaronmanela did not help to me and I found it impossible to use the skyhook with Angular 9 (with IVY enabled) so far 😞

[ErynManela]

Did you try using 1.4.0-rc0 branch @palpatine1991 ?

Also the ngcc postinstall fixes will no longer be recommended in Angular 9.1 as they have made it better.

[palpatine1991]

Yes, I am using skyhook 1.4.0-rc0 and I have tried it even with Angular 9.1.0. Still have the same error

[trakhimenok]

@cormacrelf do you plan to update examples to Angular 9.* with Ivy enabled? The "@angular-skyhook/core": "^1.4.0-rc.0" does not work with Ivy enabled for me.

[acb122]

@cormacrelf I have made a PR which fixes the library for IVY. Could you please review it, happy to take any feedback on it, you will see it is very basic fix to make the ngcc compiler happy.
#571

[palpatine1991]

@acb122 is the core of your fix adding the missing exports, upgrading dependencies or disabling the IVY?

I mean if IVY disabling is not a core of the fix, I would consider to keep it on because of future maintainability

[acb122]

@palpatine1991 the core fix is the missing exports.

IVY disabled is the current recommended setting in angular libraries in angular v10 that will change.

I have removed my upgrading angular change as that broke tests.

[MarioC3]

Hey @cormacrelf, first of all, thanks for maintaining this library!
I was wondering when will you be able to merge PR #571 made by @acb122 ?
We're having problems with Angular 9 and this library!

Thanks again!

[a7md0]

Is there any update on this? Have anyone published #571 to new NPM package

[nzbin]

@palpatine1991 @acb122 @aaronmanela @MarioC3 @a7md0
I have published the fixed version to npm, everything is fine with angular ivy.
@ng-dnd/core
@ng-dnd/multi-backend
@ng-dnd/sortable