Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the .NET coding style #309

Closed
mrbiggred opened this issue Apr 29, 2021 · 0 comments · Fixed by #310
Closed

Follow the .NET coding style #309

mrbiggred opened this issue Apr 29, 2021 · 0 comments · Fixed by #310
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mrbiggred
Copy link
Contributor

mrbiggred commented Apr 29, 2021

Update Freshli-Lib to follow the .NET coding style. This decision was reached after some internal discussions about code styles. The only difference is we will have a line length of 140 characters. This will be a soft limit that is checked by linters but can be ignored if needed.

A high level plan of the changes is:

  1. Freshli-Lib's .editorconfig should be replaced by .NET's .editorconfig.

  2. Setup a an formatter to auto-format the code during builds. Thinking of using format from .NET. Run the auto-formatter for this PR.

  3. Update Code Climate and ECLint configs if needed to support the new coding styles. During this step we should also check ECLint is still needed with Format being used.

@mrbiggred mrbiggred added the enhancement New feature or request label Apr 29, 2021
@mrbiggred mrbiggred added this to the v0.4.0 milestone Apr 29, 2021
@mrbiggred mrbiggred self-assigned this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant