Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trojan in setup #496

Closed
6 tasks
rrdirnens opened this issue Nov 29, 2019 · 3 comments
Closed
6 tasks

Trojan in setup #496

rrdirnens opened this issue Nov 29, 2019 · 3 comments

Comments

@rrdirnens
Copy link

My Environment

  • Windows 10

I'm using NVM4W version:

latest

I have already...

  • read the README to be aware of npm gotchas & antivirus issues.
  • reviewed the wiki to make sure my issue hasn't already been resolved.
  • verified I'm using an account with administrative privileges.
  • searched the issues (open and closed) to make sure this isn't a duplicate.
  • made sure this isn't a question about how to use NVM for Windows, since gitter is used for questions and comments.

My issue is related to (check only those which apply):

Setup file

Expected Behavior

Not to have a trojan warning pop up

Actual Behavior

Trojan warning popping up:
image

This happens right after download, without even opening file.

@coreybutler
Copy link
Owner

coreybutler commented Nov 30, 2019

These warnings are vendor-specific. NVM4W has passed all major tests, so I'm guessing the antivirus app in question is flagging the entire Go language. These are false positives, but it's ultimately up to the AV vendor to update their definitions.

Which Antivirus are you using? Did you download from the releases here on Github or somewhere else?

@rrdirnens
Copy link
Author

Using 360 total security, downloaded nvm4w from github releases, latest version. So you think I should ignore the warning and restore the files regardless

@coreybutler
Copy link
Owner

NVM4W is safe, as long as you're downloading it from here. There have been over 1.5M downloads and nobody has ever mentioned anything destructive happening on their system. Furthermore, it appears QiHoo does have a fair number of false positives. See https://security.stackexchange.com/questions/153851/qihoo-360s-antivirus-false-positive-rate.

It also looks like the company hasn't been straightforward in its testing practices in the past. See QIHOO 360 CAUGHT CHEATING IN ANTIVIRUS TESTING. Your call, but with a track record like that, I'd be inclined to use a different antivirus.

Closing this issue since it's a vendor-specific false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants