Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRow: Additional props are not passed to underlying component #406

Closed
jasperfirecai2 opened this issue Sep 2, 2024 · 0 comments
Closed

Comments

@jasperfirecai2
Copy link
Contributor

jasperfirecai2 commented Sep 2, 2024

  • Operating system and version
    • WSL 2 & Windows 11
  • Browser and version
    • Firefox Stable
  • A reduced test case or suggested fix using CodePen or JS Bin
    • Reduced test case: On a blank page, Create a CRow component with HTML-specific props, except className. e.g. onMouseOver, onDragEnter, etc. These event listeners do not function.

extra props in CRow get reduced into ...rest, which is then never used again outside of breakpoints. This is a pretty serious issue for those migrating, because it used to pass props, and pretty much every other component does pass props.

see

({ children, className, ...rest }, ref) => {
and
<div className={classNames('row', repsonsiveClassNames, className)} ref={ref}>

suggested fix:

    return (
      <div {...rest} className={classNames('row', repsonsiveClassNames, className)} ref={ref}>
        {children}
      </div>
    )

#407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant