Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xvfb error #1911

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

dturopoli
Copy link
Contributor

@dturopoli dturopoli commented Mar 16, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

The comment in code suggests that XVFB is optional, so getter for XVFB shouldn't throw exception.
// use xvfb if possible

Also process needs to be created in a different way.

@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Mar 16, 2022
@dpfaffenbauer dpfaffenbauer merged commit bb08732 into coreshop:master Mar 16, 2022
@dpfaffenbauer
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants