Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix: ProductRepository: Added missing placeholder #1708

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

lukadschaak
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -

Was a pull request some time ago. So this is "The Return of the Jed...", I mean: This is a new try ;-)

@dpfaffenbauer
Copy link
Member

please rebase to 2.2, 2.0 is not maintained anymore

dpfaffenbauer and others added 2 commits August 3, 2021 11:27
Was a pull request some time ago. So this is "The Return of the Jed...", I mean: This is a new try ;-)
@dpfaffenbauer
Copy link
Member

your fix is legit and works. CI just has a problem installing mysql.

@dpfaffenbauer dpfaffenbauer merged commit 094f45a into coreshop:2.2 Aug 3, 2021
@dpfaffenbauer dpfaffenbauer added this to the 2.2.10 milestone Aug 3, 2021
@dpfaffenbauer dpfaffenbauer self-requested a review August 3, 2021 14:28
@dpfaffenbauer
Copy link
Member

thanks a lot @lukadschaak

@lukadschaak
Copy link
Contributor Author

Yeah pipelines.. we all know it.. Thank for merging 👍

@lukadschaak lukadschaak deleted the patch-2 branch August 3, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants