[Dynamic Dropdowns] Fix data persistence for class definition and database #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongerig
force-pushed
the
fix/dynamic-dropdowns
branch
from
b076d99 to
dc298cd
Compare
|
please remove return types, we don't do that within 2.x, that comes with 3.x |
|
Done |
dpfaffenbauer
approved these changes
Apr 8, 2020
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic Dropdown fields didn't save some data correctly into class definition files (also reading from it was a problem). Also, saving data into database, when saving a pimcore object didn't work properly.
This PR should fix this.