Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][3.0] strict types #1294

Merged
merged 22 commits into from
Mar 5, 2020

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #1274

this pr also includes #1289

@dpfaffenbauer dpfaffenbauer added this to the 3.0.0 milestone Feb 19, 2020
@dpfaffenbauer dpfaffenbauer requested a review from a team February 19, 2020 12:17
@dpfaffenbauer dpfaffenbauer self-assigned this Feb 19, 2020
@dpfaffenbauer dpfaffenbauer changed the title [3.0] strict types [WIP][3.0] strict types Feb 19, 2020
@dpfaffenbauer dpfaffenbauer force-pushed the 3.0-features/strict-types branch 2 times, most recently from 23cd087 to a9201d5 Compare February 19, 2020 14:20
# Conflicts:
#	src/CoreShop/Bundle/CoreBundle/Customer/RegistrationService.php
#	src/CoreShop/Bundle/CoreBundle/Security/ObjectUserProvider.php
#	src/CoreShop/Bundle/CustomerBundle/Pimcore/Repository/CustomerRepository.php
#	src/CoreShop/Bundle/ResourceBundle/Validator/Constraints/UniqueEntityValidator.php
#	src/CoreShop/Component/Customer/Repository/CustomerRepositoryInterface.php
@dpfaffenbauer dpfaffenbauer merged commit a08decc into coreshop:3.0 Mar 5, 2020
@dpfaffenbauer dpfaffenbauer deleted the 3.0-features/strict-types branch March 5, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant