Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] NestedConditionChecker NOT validation broken #2445

Closed
solverat opened this issue Nov 13, 2023 · 1 comment
Closed

[Bug] NestedConditionChecker NOT validation broken #2445

solverat opened this issue Nov 13, 2023 · 1 comment
Assignees
@solverat @dpfaffenbauer
Labels
bug
Milestone
3.1.5

Comments

@solverat
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Within this huge commit, the variable $valid changed to $conditionValid:

image

That means, that if you're using the NOT operator, $valid will always be false and therefor the rule always returns true.
@solverat solverat changed the title [Bug] NestedConditionChecker validation broken [Bug] NestedConditionChecker NOT validation broken Nov 13, 2023
@solverat solverat mentioned this issue Nov 14, 2023
Merged
@dpfaffenbauer
Copy link
Member

thanks a lot for the PR @solverat

@dpfaffenbauer dpfaffenbauer added this to the 3.1.5 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solverat solverat

@dpfaffenbauer dpfaffenbauer

Labels
bug
Projects
None yet
Milestone
3.1.5
Development

No branches or pull requests
2 participants
@solverat @dpfaffenbauer