From 454139d41b674e2a0a197c3132dc1596afd1a9e2 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sun, 17 Jul 2016 16:43:20 -0400 Subject: [PATCH] upgrade: Print changed packages again First I noticed we needed to query the new default *after* the transaction had run. Then, I noticed the obvious embarassing logic error. Fixes: 3f1e7c85a18182669899f4065d23fec6ac0962c Closes: #396 Closes: #397 Approved by: jlebon --- src/app/rpmostree-builtin-upgrade.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/rpmostree-builtin-upgrade.c b/src/app/rpmostree-builtin-upgrade.c index 8c4f027e68..bf323f3145 100644 --- a/src/app/rpmostree-builtin-upgrade.c +++ b/src/app/rpmostree-builtin-upgrade.c @@ -129,14 +129,14 @@ rpmostree_builtin_upgrade (int argc, goto out; } - new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy); - if (!rpmostree_transaction_get_response_sync (sysroot_proxy, transaction_address, cancellable, error)) goto out; + new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy); + if (opt_preview || opt_check) { g_autoptr(GVariant) result = NULL; @@ -169,7 +169,7 @@ rpmostree_builtin_upgrade (int argc, if (previous_default_deployment == new_default_deployment) changed = FALSE; else - changed = g_variant_equal (previous_default_deployment, new_default_deployment); + changed = !g_variant_equal (previous_default_deployment, new_default_deployment); if (!changed) {