Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers: add "akamai" provider #1841

Merged
merged 1 commit into from
Apr 12, 2024
Merged

providers: add "akamai" provider #1841

merged 1 commit into from
Apr 12, 2024

Conversation

nesv
Copy link
Contributor

@nesv nesv commented Mar 26, 2024 •
edited
Loading

The "akamai" provider adds support for retrieving an ignition configuration from Akamai Connected Cloud's (a.k.a. Linode) Metadata Service.

See flatcar/Flatcar#1404
See coreos/fedora-coreos-tracker#1701

@nesv nesv force-pushed the provider.akamai branch from a8f06c2 to 3c3821e Compare March 26, 2024 14:56
@prestist
Copy link
Collaborator

prestist commented Mar 26, 2024 •
edited
Loading

Thank you for working on this!

Could you create a platform request issue on https://github.com/coreos/fedora-coreos-tracker/issues and add it to this issue's work? There a a number of moving parts so it would be nice to track it there :)

@nesv nesv mentioned this pull request Mar 27, 2024
Open
@nesv
Copy link
Contributor Author

nesv commented Mar 27, 2024

Thank you for working on this!

Could you create a platform request issue on https://github.com/coreos/fedora-coreos-tracker/issues and add it to this issue's work? There a a number of moving parts so it would be nice to track it there :)

Hi @prestist! You're most welcome! I have filed a tracking ticket: coreos/fedora-coreos-tracker#1701.

@travier
Copy link
Member

travier commented Mar 27, 2024

Can you add Fixes: https://github.com/coreos/ignition/issues/1508 ? Thanks!

@nesv
Copy link
Contributor Author

nesv commented Mar 27, 2024

For what it's worth, I'll add any requested changes as fixup commits just so that comments stay with the referenced code. I will rebase to squash out the fixup commits prior to merging if everything looks good.

@nesv nesv force-pushed the provider.akamai branch 2 times, most recently from 68b1d18 to 62725fd Compare March 27, 2024 14:27
@nesv nesv requested a review from tormath1 March 27, 2024 14:27
@nesv
Copy link
Contributor Author

nesv commented Mar 27, 2024

Can you add Fixes: https://github.com/coreos/ignition/issues/1508 ? Thanks!

I have added it to the commit message for 6cb1703.

tormath1
tormath1 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nesv should we kick-off a Flatcar build with this patch in order to provide an image that you could test on Linode? We would catch any issue before merging this PR.

@nesv
Copy link
Contributor Author

nesv commented Mar 27, 2024

LGTM. @nesv should we kick-off a Flatcar build with this patch in order to provide an image that you could test on Linode? We would catch any issue before merging this PR.

@tormath1 If you could, that would be great! 😄

@tormath1 tormath1 mentioned this pull request Mar 27, 2024
Merged
4 tasks
@prestist
Copy link
Collaborator

@nesv Thank you for being so quick to address our comments!

@nesv
Copy link
Contributor Author

nesv commented Mar 27, 2024

@nesv Thank you for being so quick to address our comments!

@prestist You're most welcome!

tormath1
tormath1 reviewed Mar 29, 2024
View reviewed changes
internal/providers/akamai/akamai.go Outdated Show resolved Hide resolved
internal/providers/akamai/akamai.go Outdated Show resolved Hide resolved
internal/resource/url.go Outdated Show resolved Hide resolved
@nesv
Copy link
Contributor Author

nesv commented Apr 1, 2024

@tormath1 Latest changes have been pushed!

nesv pushed a commit to nesv/afterburn that referenced this pull request Apr 1, 2024
providers: Add "akamai" provider
7a5cf1a 
The "akamai" provider adds support for retrieving an ignition
configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata
Service][metadata-service].

References: flatcar/Flatcar#1404
References: coreos/fedora-coreos-tracker#1701
References: coreos/ignition#1841

[metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
nesv pushed a commit to nesv/afterburn that referenced this pull request Apr 1, 2024
providers: Add "akamai" provider
983e9ac 
The "akamai" provider adds support for retrieving configuration from
Akamai Connected Cloud's (a.k.a. Linode) [Metadata
Service][metadata-service].

References: flatcar/Flatcar#1404
References: coreos/fedora-coreos-tracker#1701
References: coreos/ignition#1841

[metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
@nesv nesv mentioned this pull request Apr 1, 2024
Merged
@nesv nesv force-pushed the provider.akamai branch from 71f71bc to 6de76af Compare April 4, 2024 20:29
@nesv
Copy link
Contributor Author

nesv commented Apr 4, 2024

@tormath1 The latest image you provided works!

I have squashed out all of the fixup commits.

jlebon
jlebon approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but looks sane to me overall.
Release note commit would probably be cleaner squashed.

internal/providers/akamai/akamai.go Show resolved Hide resolved
internal/providers/akamai/akamai.go Outdated Show resolved Hide resolved
internal/providers/akamai/akamai.go Outdated Show resolved Hide resolved
internal/providers/akamai/akamai.go Outdated Show resolved Hide resolved
@nesv nesv force-pushed the provider.akamai branch from 6de76af to 4415a93 Compare April 5, 2024 17:50
@nesv
Copy link
Contributor Author

nesv commented Apr 5, 2024

@jlebon Thank you for the review! I've made the changes you requested.

@nesv nesv force-pushed the provider.akamai branch from 4415a93 to 9f4ff0c Compare April 5, 2024 17:59
providers: add "akamai" provider
9b833b2 
The "akamai" provider adds support for retrieving an ignition
configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata
Service][1].

See: flatcar/Flatcar#1404
See: coreos/fedora-coreos-tracker#1701
Fixes: coreos#1508

[1]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/

docs: Add Akamai/Linode provider to release notes
@nesv nesv force-pushed the provider.akamai branch from 9f4ff0c to 9b833b2 Compare April 5, 2024 19:40
jlebon
jlebon approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will hand it off to @prestist.

@nesv
Copy link
Contributor Author

nesv commented Apr 5, 2024

LGTM!

Will hand it off to @prestist.

Thank you very much, @jlebon!

tormath1
tormath1 reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this patch has been tested with Flatcar images on Linode. On the functional aspect, it works as expected.

nesv pushed a commit to nesv/afterburn that referenced this pull request Apr 10, 2024
providers: Add "akamai" provider
21961f5 
The "akamai" provider adds support for retrieving configuration from
Akamai Connected Cloud's (a.k.a. Linode) [Metadata
Service][metadata-service].

References: flatcar/Flatcar#1404
References: coreos/fedora-coreos-tracker#1701
References: coreos/ignition#1841

[metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
@jlebon jlebon merged commit 5c7c765 into coreos:main Apr 12, 2024
9 checks passed
@nesv nesv deleted the provider.akamai branch April 15, 2024 14:50
nesv pushed a commit to nesv/afterburn that referenced this pull request Apr 19, 2024
providers: Add "akamai" provider
bacbf84 
The "akamai" provider adds support for retrieving configuration from
Akamai Connected Cloud's (a.k.a. Linode) [Metadata
Service][metadata-service].

References: flatcar/Flatcar#1404
References: coreos/fedora-coreos-tracker#1701
References: coreos/ignition#1841

[metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

@pothos pothos pothos left review comments

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nesv @prestist @travier @pothos @jlebon @tormath1