Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctlv3: use printer for lease command results #7785

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

heyitsanthony
Copy link
Contributor

Fixes #7783

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@85c9ea9). Click here to learn what that means.
The diff coverage is 25.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7785   +/-   ##
=========================================
  Coverage          ?   75.76%           
=========================================
  Files             ?      331           
  Lines             ?    26105           
  Branches          ?        0           
=========================================
  Hits              ?    19778           
  Misses            ?     4894           
  Partials          ?     1433
Impacted Files Coverage Δ
etcdctl/ctlv3/command/printer_fields.go 0% <0%> (ø)
etcdctl/ctlv3/command/printer.go 40.65% <11.11%> (ø)
etcdctl/ctlv3/command/lease_command.go 67.07% <50%> (ø)
etcdctl/ctlv3/command/printer_simple.go 55.38% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c9ea9...cf8c66c. Read the comment docs.

@heyitsanthony heyitsanthony merged commit 633a4e6 into etcd-io:master Apr 20, 2017
@heyitsanthony heyitsanthony deleted the printerize-lease branch April 20, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants