snap: fix write snap #7282
Merged
snap: fix write snap #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use writeFile since it does not sync file before closing. This can lead to slient file corruption when disk is full.
|
LGTM. It seems CI has an issue? We have to do a 2.3.8 release for this. It would take a month or so to get into CoreOS stable. /cc @crawford We will ping you when 2.3.8 is released. |
|
I think the CI failure is benign; semaphore's been updated a bit and the compile errors seem unrelated... |
|
LGTM |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use writeFile since it does not sync file before closing.
This can lead to slient file corruption when disk is full.