clientv3: let watchers cancel when reconnecting #6816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Nov 7, 2016
| // receive data from new grpc stream | ||
| go w.serveWatchClient(wc) | ||
| return wc, nil | ||
| } | ||
|
|
||
| func (w *watchGrpcStream) waitCancelSubstreams() (chan<- struct{}, <-chan struct{}) { |
There was a problem hiding this comment.
waitCancelSubStreams(stopc chan <-struct{}) <-chan struct{}
There was a problem hiding this comment.
let's pass in the stopc instead of returning it?
|
LGTM |
heyitsanthony
force-pushed
the
fix-disconn-cancel
branch
2 times, most recently
from
f097adf to
1aeeb38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @yudai