etcdmain: configurable 'etcd' binary log-output #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Nov 3, 2016
| @@ -139,6 +139,8 @@ logging flags | |||
| enable debug-level logging for etcd. | |||
| --log-package-levels '' | |||
| specify a particular log level for each etcd package (eg: 'etcdmain=CRITICAL,etcdserver=DEBUG'). | |||
| --log-output '' | |||
| specify 'stdout' or 'stderr' to skip journald logging even when running under init (ppid == 1). | |||
There was a problem hiding this comment.
even when running under systemd
xiang90
reviewed
Nov 3, 2016
| @@ -184,6 +184,7 @@ func newConfig() *config { | |||
| // logging | |||
| fs.BoolVar(&cfg.Debug, "debug", false, "Enable debug-level logging for etcd.") | |||
| fs.StringVar(&cfg.LogPkgLevels, "log-package-levels", "", "Specify a particular log level for each etcd package (eg: 'etcdmain=CRITICAL,etcdserver=DEBUG').") | |||
| fs.StringVar(&cfg.LogOutput, "log-output", "", "Specify 'stdout' or 'stderr' to skip journald logging even when running under init (ppid == 1).") | |||
There was a problem hiding this comment.
we do not need to add this to cfg. the main pkg takes care of it anyway.
|
LGTM. defer to @heyitsanthony |
gyuho
changed the title
| @@ -184,6 +185,7 @@ func newConfig() *config { | |||
| // logging | |||
| fs.BoolVar(&cfg.Debug, "debug", false, "Enable debug-level logging for etcd.") | |||
| fs.StringVar(&cfg.LogPkgLevels, "log-package-levels", "", "Specify a particular log level for each etcd package (eg: 'etcdmain=CRITICAL,etcdserver=DEBUG').") | |||
| fs.StringVar(&cfg.logOutput, "log-output", "", "Specify 'stdout' or 'stderr' to skip journald logging even when running under systemd.") | |||
There was a problem hiding this comment.
The systemd/journald stuff seems forced, maybe:
fs.StringVar(&cfg.logOutput, "log-output", "default", "Specify a logging target (stdout,stderr,default).")
|
@heyitsanthony @xiang90 All fixed. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@heyitsanthony @xiang90
Fix #5449