clientv3: drop Config.Logger field #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. this needs to be added into release note. we slightly change the api. |
|
Ok will include this in the release note. |
heyitsanthony
suggested changes
Oct 11, 2016
| logger.set(log.New(os.Stderr, "", log.LstdFlags)) | ||
|
|
||
| // disable client side grpc by default | ||
| grpclog.SetLogger(log.New(ioutil.Discard, "", 0)) |
There was a problem hiding this comment.
this is racey iirc, that's why this logger thing exists in the first place-- the logger has to override the grpclog at initialization so that any changes to the grpclog go through logger with locking instead of through SetLogger; it should be grpclog.SetLogger(&logger) then only updates through logger.set(l).
logger.l = log.New(io.util.Discard, "", 0))
grpclog.SetLogger(&logger)There was a problem hiding this comment.
@heyitsanthony You are right, I forgot about that.
Just fixed and adds more comments with your feedback.
PTAL.
Thanks!
gyuho
force-pushed
the
clientv3-logger
branch
2 times, most recently
from
d2bd3a7 to
2cfb392
Compare
Fix etcd-io#6603. Instead adds 'SetLogger' to set global logger interface to avoid unnecessary logger updates.
gyuho
force-pushed
the
clientv3-logger
branch
from
2cfb392 to
084c407
Compare
|
lgtm. the comments are helpful |
heyitsanthony
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6603.
Instead adds 'SetLogger' to set global logger interface
to avoid unnecessary logger updates.
/cc @heyitsanthony @xiang90 @chzyer