wal: fix CRC corruption on writes following write tears #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 25, 2016 14:24
Whenever the WAL is opened for writes, it should write zeroes to its tail starting from the first zero record. Otherwise, if there are entries past the first zero record due to a torn write, any new writes that overlap the old entries will lead to a garbage record on the tail and cause a CRC mismatch.
| } | ||
|
|
||
| b = make([]byte, 512) | ||
| if _, err = f.Read(b); err != nil { |
There was a problem hiding this comment.
Is this for reading the next 512 bytes from os.SEEK_CUR?
There was a problem hiding this comment.
yeah, it's for checking that everything past SEEK_CUR was actually zero'd out
|
lgtm. Thanks! Defer to @xiang90 |
|
LGTM. Before merging this, @gyuho can you run this patch with failpoint enabled and qps=2500? |
|
@xiang90 Ok let me test run this with failpoints. |
|
@heyitsanthony Let's get this merged! Confirmed this fixed the wal corruption issue. |
This was referenced Aug 26, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.