session: remove session manager and add ttl #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @heyitsanthony |
| @@ -39,17 +39,14 @@ type Election struct { | |||
| } | |||
|
|
|||
| // NewElection returns a new election on a given key prefix. | |||
| func NewElection(client *v3.Client, pfx string) *Election { | |||
| func NewElection(client *ClientWithSession, pfx string) *Election { | |||
There was a problem hiding this comment.
@heyitsanthony Is this what you want? In your example, election only takes session as arg. But it is not enough since we still need to create keys by using the client for example.
There was a problem hiding this comment.
@xiang90 Just NewElection(s *Session, pfx string). The Session can have a function func (s *Session) Client() *clientv3.Client { return s.client} for anything that needs to access etcd through the session. The ClientWithSession struct probably doesn't need to be part of the concurrency package.
| if ttl <= 0 { | ||
| so.ttl = defaultSessionTTL | ||
| } | ||
| so.ttl = ttl |
|
lgtm aside from broken ttl stuff |
xiang90
force-pushed
the
session
branch
4 times, most recently
from
f21712d to
9a53d2c
Compare
This was referenced Aug 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TTL support, and also remove the session manager.
The plan is to have a sessionClient that embeds a client with its session. So the client can inspect its session more easily.