clientv3: support non-blocking New() #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,9 @@ type Config struct { | |||
| // DialTimeout is the timeout for failing to establish a connection. | |||
| DialTimeout time.Duration | |||
|
|
|||
| // DialNoWait, when true, returns a Client before establishing a connection. | |||
| DialNoWait bool | |||
There was a problem hiding this comment.
shall we make dialNoWait true by default?
heyitsanthony
force-pushed
the
clientv3-nonblock-new
branch
from
1902a14 to
3fc0a53
Compare
heyitsanthony
changed the title
|
lgtm |
heyitsanthony
force-pushed
the
clientv3-nonblock-new
branch
from
3fc0a53 to
429d5ab
Compare
|
can this get picked to 3-branch? |
|
@timothysc Yes. It will happen soon. We are now blocked by some gRPC issues again for a new release. :( |
|
Is there a pending 3.0.5 we should be aware of, or are we good with 3.0.4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6162