Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3/integration: fix race in TestWatchCompactRevision #5990

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jul 19, 2016

Fix #5982

Reduce the cluster size to 1 for this test. It is not necessary to have a 3 member cluster for this test at the first place.

If we use a 3 member cluster, the watch request might arrive before the compaction propagates to that member. Then watch with rev 2 will succeed.

@heyitsanthony
Copy link
Contributor

heyitsanthony commented Jul 19, 2016

@xiang90 I recall the intent for 3 members was to ensure the compact propagated. I think the fix would be a linearized read before the watch?

@xiang90
Copy link
Contributor Author

xiang90 commented Jul 19, 2016

@heyitsanthony This is a test for client, not for etcd server. I feel we should not test propagation here.

@heyitsanthony
Copy link
Contributor

ok lgtm

@xiang90 xiang90 merged commit d3d954d into etcd-io:master Jul 19, 2016
@xiang90 xiang90 deleted the wcr branch July 19, 2016 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants