Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add configurable delay for each check #1186

Open
HeCorr opened this issue Jan 17, 2022 · 2 comments
Open

[Request] Add configurable delay for each check #1186

HeCorr opened this issue Jan 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@HeCorr
Copy link

HeCorr commented Jan 17, 2022

Is your feature request related to a problem? Please describe.
My bot has rate limiting implemented and Corde runs command checks too quickly, which ends up being rate limited:

image

Describe the solution you'd like
A global configurable delay for sending individual commands and potentially a per-command parameter (like timeout).

Describe alternatives you've considered
Maybe this would work? I haven't tested it yet.
Nope, I just tested it and all it does is hang for a long time before executing all the commands without any delay between them.

image

@lucasgmagalhaes lucasgmagalhaes added the enhancement New feature or request label Jan 19, 2022
@lucasgmagalhaes lucasgmagalhaes self-assigned this Jan 19, 2022
@lucasgmagalhaes
Copy link
Collaborator

Hi, again @HeCorr. This is really helpful. Thank you for the suggestion. The code that you just showed does not work because corde adds each expect call into a queue that basically ignores all the rest of the code inside the test statement '-' (I know, it is terrible. I'm working on it).

@HeCorr
Copy link
Author

HeCorr commented Jan 19, 2022

Don't worry about it. :)

Most smaller bots don't have rate limiting implemented so it makes sense that such feature hasn't been requested yet.

I would try writing a PR for this but I'm busy at the moment and honestly rather rusty with Typescript.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants