New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BDWGC + get rid of build hack for signals #250

Closed

plajjan opened this issue Dec 11, 2023 · 3 comments

plajjan commented Dec 11, 2023

Just FYI, I opened an issue and @ivmai, the maintainer of the BDW GC fixed so that signals are now conditionally included. Thus it should be possible to remove the build hack you have in https://github.com/anuraaga/coraza-proxy-wasm/blob/90a30fc2c3b338f3fcd7e62edee58921b40f60ee/buildtools/bdwgc/Dockerfile#L12 if you upgrade the GC!

Member

M4tteoP commented Dec 11, 2023

Thanks for pointing it out! The GC is now a dependency of coraza-proxy-wasm and is under https://github.com/wasilibs/nottinygc, but the build hack is here: https://github.com/wasilibs/nottinygc/blob/71b98371a0f408aed22934e02aa029077de2bf02/buildtools/bdwgc/Dockerfile#L16C49-L16C49. So it might totally worth it to address it at the next GC upgrade :)

Member

jcchavezs commented Dec 11, 2023

Contributor

anuraaga commented Dec 12, 2023 •

edited

Loading

Thanks @plajjan! That's great news - I incorporated the update to nottinygc.

wasilibs/nottinygc#45

anuraaga closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment