Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts: Instruction decoder should decode hex strings #545

Closed
armaniferrante opened this issue Jul 23, 2021 · 4 comments · Fixed by #547
Closed

ts: Instruction decoder should decode hex strings #545

armaniferrante opened this issue Jul 23, 2021 · 4 comments · Fixed by #547
Labels
good first issue Good for newcomers help wanted Extra attention is needed ts

Comments

@armaniferrante
Copy link
Member

armaniferrante commented Jul 23, 2021 •
edited
Loading

Currently it decodes Buffer's and base 58 strings. Instead of base 58 it should decode hex by default. To decode base58, an optional parameter should be passed in describing how to interpret the string.

See https://github.com/project-serum/anchor/blob/master/ts/src/coder/instruction.ts#L112.
@armaniferrante armaniferrante added help wanted Extra attention is needed good first issue Good for newcomers ts labels Jul 23, 2021
@masonwoodford
Copy link

Hello could I work on this?

@armaniferrante
Copy link
Member Author

Hello could I work on this?

Please do!

@masonwoodford
Copy link

Hello could I work on this?

Please do!

Apologies I am new to contributing, I didn't realize this was in Rust, I had thought Python! I don't think I'll be able to figure this out, sorry about that! You can delete my comments to not confuse others if you want.

@fanatid
Copy link
Contributor

fanatid commented Jul 24, 2021

I'll submit PR for this issue today.

@fanatid fanatid mentioned this issue Jul 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed ts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ts: Use hex by default for decoding Instruction fanatid/anchor
3 participants
@fanatid @armaniferrante @masonwoodford