Typescript complains when .accounts() from MethodNamespace is missing an account

[danmt]

Description

MethodsNamespace has a mechanism to resolve accounts, with this we can avoid common accounts like SystemProgram, as well as PDAs since they are auto-populated.

Problem

Due to this change, the accounts parameter is no longer any, which is awesome but now Typescript complains when not all the accounts are provided. This makes it impossible to use the account resolver logic.

Proposed Solution

While it isn't pretty, we could wrap the accounts method parameter with Partial. This would bypass the error but makes it possible for developers to make a method call with required accounts missing. I think a better solution would be a mechanism to differentiate mandatory from optional accounts.

NOTE: I'm creating this issue without a PR because I'm not entirely sure which would be the best way to go.

[callensm]

ah yep, i'll fix this...just needs an Exclude wrapper for the account names for the ones handled by the resolver.

[danmt]

I like that solution much better. I'm far from good when it comes to Typescript complex types... As a hotfix for my use case, I did the Partial thing I mentioned and it works but yeah, it's kinda crappy.

My concern with Exclude is that I thought that you could either let the resolver put the accounts for you or you can put it manually. The Exclude might prevent users from manually adding an account, but I'm not sure if that's even an expected use-case.

[callensm]

My thinking was that if we have an account resolver built in for things like systemProgram, tokenProgram, etc. then we should start discouraging / preventing people from providing it manually to prevent mistakes. In that case, Exclude would be perfect.

[danmt]

Totally agree with systemProgram and so on, but I'm not entirely convinced on PDAs, don't know why I gotta feel that someone might need to add a PDA account manually. This isn't my case, but don't know, that's my concern.

[callensm]

This would be a patch to prevent purely for the global chain programs mentions above from being manually added.

[danmt]

That means PDA accounts would still need to be manually added?

[danmt]

Looking at this condition it seems like we need to Exclude global chain programs and accounts at PDAs should be optional, so autoPopulate is called only when the account wasn't provided.

[callensm]

I'm almost done with the PR and will link to this issue to see what my resolution was.

[danmt]

Just read the PR and it seems to cover the global chain programs part. But I don't think it solves the issue for accounts at PDAs, the accounts method will still ask for those accounts even though they could be auto-populated.