ts: instanceof PublicKey not working

[paul-schaaf]

I discovered this while working on #1098

The PR adds an error that is thrown when translateAddress receives an object that is not a string or a public key so that callers of the function can handle it.

I initially tried using address instanceof PublicKey for this but it made some tests fail by throwing the error so I thought these tests are passing something else into translateAddress and the test is written wrong. But it isnt. I logged the prototype chain of what is actually passed in in the test and it is a PublicKey.

e.g.

🚨🚨🚨🚨🚨🚨
PublicKey {
  _bn: <BN: a90a662a139208a9b9f0d7de6e5577324bf718f3e416fc0e23d4e0fdd256c82f>
}
 -> PublicKey -> Struct -> Object

but for some reason instanceof PublicKey fails

[fanatid]

Maybe PublicKey comes from different package locations?
What npm why @solana/web3.js show?

[paul-schaaf]

there is no command npm why for me

I also tried doing sth like instance of @solana/web3.js.Pubkey || instance of anchor.web3.Pubkey to no avail

[fanatid]

Maybe old node version?

$ npm why @solana/web3.js
@solana/[email protected]
node_modules/@solana/web3.js
  @solana/web3.js@"^1.17.0" from @project-serum/[email protected]
  node_modules/@project-serum/anchor
    @project-serum/anchor@"=0.18.0" from the root project
  peer @solana/web3.js@"^1.2.0" from @project-serum/[email protected]
  node_modules/@project-serum/borsh
    @project-serum/borsh@"^0.2.2" from @project-serum/[email protected]
    node_modules/@project-serum/anchor
      @project-serum/anchor@"=0.18.0" from the root project
    @project-serum/borsh@"^0.2.2" from @project-serum/[email protected]
    node_modules/@project-serum/serum/node_modules/@project-serum/anchor
      @project-serum/anchor@"^0.11.1" from @project-serum/[email protected]
      node_modules/@project-serum/serum
        dev @project-serum/serum@"^0.13.41" from the root project
  @solana/web3.js@"^1.21.0" from @project-serum/[email protected]
  node_modules/@project-serum/serum
    dev @project-serum/serum@"^0.13.41" from the root project
  @solana/web3.js@"^1.17.0" from @project-serum/[email protected]
  node_modules/@project-serum/serum/node_modules/@project-serum/anchor
    @project-serum/anchor@"^0.11.1" from @project-serum/[email protected]
    node_modules/@project-serum/serum
      dev @project-serum/serum@"^0.13.41" from the root project
  @solana/web3.js@"^1.21.0" from @solana/[email protected]
  node_modules/@solana/spl-token
    dev @solana/spl-token@"^0.1.8" from the root project
    @solana/spl-token@"^0.1.6" from @project-serum/[email protected]
    node_modules/@project-serum/serum
      dev @project-serum/serum@"^0.13.41" from the root project
$ node --version
v17.2.0
$ npm --version
8.1.4

[paul-schaaf]

just updated to lts, same issue still occurs

[paul-schaaf]

im closing this for now until it shows up somewhere else and causes problems because #1138 has a better fix than #1098