Local update failures are silently ignored

[mtoohey31]

I happened to notice a bunch of warnings in my gickup service logs, and upon further investigation I realized nothing had been mirroring properly for a while. To avoid this happening in the future, I was going to set up a Prometheus alert, but then I realized that there was no indication of an issue in the Prometheus metrics. I've taken a look at the source code and it looks like local.Locally will return true even when the final retry fails? To be specific, it seems to me like this line should be return false instead of break. Does that sound right, or am I missing something?

[cooperspencer]

You are correct. If we change that line, it should work the way we expect it to.

[cooperspencer]

Can you test that?
#271

you can download the artifact from here:
https://github.com/cooperspencer/gickup/actions/runs/10697068567

[mtoohey31]

Thanks for taking a look. I've tested it and that fixes things!

[cooperspencer]

thanks for testing. I'll merge it and push a new release.

[mtoohey31]

No problem, thank you!