Loop when player is running #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aying. Demo was updated accordingly
SkinyMonkey
commented
Oct 23, 2017
src/demo/App.js
Outdated
| @@ -132,7 +137,7 @@ export default class App extends Component { | |||
| onPause={this.onPause} | |||
| onBuffer={() => console.log('onBuffer')} | |||
| onSeek={e => console.log('onSeek', e)} | |||
| onEnded={() => this.setState({ playing: false })} | |||
| onEnded={() => this.setState({ playing: loop ? true : false })} | |||
There was a problem hiding this comment.
Useless ternary, 'don't know what I was thinking about.
|
I like the idea, but don't forget to run |
|
Sorry for that, It should be fixed now. |
|
Nice work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the loop option to be activable even if the player is already playing.
I updated demo accordingly to test if you want to check it.
Thank you for this great component by the way!