Wistia support #133
Wistia support #133
Conversation
Firefox is throwing some warnings that come from the Wistia JS player. I’ll ask the Wistia folks if they know what’s going on.
| return this.player.percentWatched() | ||
| } | ||
| getFractionLoaded () { | ||
| return null |
There was a problem hiding this comment.
AFAIK, the Wistia JS player does not expose this info.
| it('fires onPlay', done => testPlay(TEST_WISTIA_URL, done)) | ||
| it('fires onDuration', done => testDuration(TEST_WISTIA_URL, done)) | ||
| it('fires onDuration with delayed load', done => testDurationDelayed(TEST_WISTIA_URL, done)) | ||
| it.skip('fires onPause', done => testPause(TEST_WISTIA_URL, done)) |
There was a problem hiding this comment.
The //fast.wistia.com/assets/external/E-v1.js Wistia JS player is outputting some errors in Firefox. The player works as expected, but it makes the tests have some output. I'll reach out to the Wistia folks to see if they know what the issue may be. I'm skipping this test as it makes the whole test suite hang.
When the react-player component is mounted in another app, each component would load the Wistia script, but we only need it once.
|
Hi @cookpete. I just merged master and added support for playback rate as well. Let me know what you think. I'd love to get Wistia support into the player. |
|
Thanks for the PR @edelgado. I've tidied things up slightly but it was mainly just me being anal about code style and consistency of stuff. Published in |
|
Thanks for the merge and cleanup @cookpete, Merry Christmas to you too :-) |
Hi Pete,
Thanks for a great React-based player. This PR adds support for Wistia videos. I followed the structure from the YouTube component and I'll leave some specific notes in the diff below.
I'd love to work with you to get Wistia support into a
react-player🙂