From f478f1a3c29cfd8c95c4f49a17ddd05b1b042bc7 Mon Sep 17 00:00:00 2001 From: Pete Cook Date: Thu, 14 Sep 2017 13:06:57 +0100 Subject: [PATCH] Remove unnecessary stop logic from soundcloud The widget is an iframe that gets unmounted, so I can't see why pausing and seeking beforehand is necessary --- src/players/Facebook.js | 2 +- src/players/SoundCloud.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/players/Facebook.js b/src/players/Facebook.js index 8f185b1a..72b4bd1f 100644 --- a/src/players/Facebook.js +++ b/src/players/Facebook.js @@ -53,7 +53,7 @@ export default class Facebook extends Base { this.callPlayer('pause') } stop () { - // No need to stop + // Nothing to do } seekTo (amount) { const seconds = super.seekTo(amount) diff --git a/src/players/SoundCloud.js b/src/players/SoundCloud.js index f380f6f9..297918ff 100644 --- a/src/players/SoundCloud.js +++ b/src/players/SoundCloud.js @@ -70,8 +70,7 @@ export default class SoundCloud extends Base { } } stop () { - this.pause() - this.callPlayer('seekTo', 0) + // Nothing to do } seekTo (amount) { const seconds = super.seekTo(amount)