New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 客户端写的太垃圾了 #64

Open

GoogleCodeExporter opened this issue Nov 2, 2015 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Nov 2, 2015

Java 客户端写的太垃圾了 
我从来没有见过这么垃圾的代码，真的。

Original issue reported on code.google.com by [email protected] on 5 May 2014 at 5:34

The text was updated successfully, but these errors were encountered:

Author

GoogleCodeExporter commented Nov 2, 2015

我看了下源码，最大的败笔是StorageClient1和一个Socket绑定，这
样的后果就是StorageClient1不是线程安全的，多线程用不了，一
个不支持多线的的Client 也配称之为Client？
好吧，写成这样也就算了，我自己用连接池来搞，代码中各��
�C语言的命名也就算了。
源码中各种e.printStackTrace(); 这打给谁看呢。不会用日志？
还有，能不能别用null返回来代表错误？有错误你就直接抛，�
��是封装了一个MyException么，虽然名字命名垃圾，不知道这个�
��常具体代表什么，但是有总比没好吧，返回个null也不抛错��
�。
虽然作者是搞C为主的，但是Java客户端的设计明显不是语言带
来的问题。

余庆，现在淘宝网Java中间件团队从事Java基础平台研发工作。
。。。
好吧，我算是见识到淘宝的Java水平了。

Original comment by [email protected] on 7 May 2014 at 3:04

GoogleCodeExporter added Priority-Medium Type-Defect auto-migrated labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment