-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows tests (CI) #59
Comments
All issues resolved, just waiting on a |
@Tapppi digging into the AppVeyor stuff, I'm pretty stumped. A few things I noticed:
CC: @nexdrew |
@bcoe, I'm gonna sum the CI shenanigans here since it's been all over the place now. @nexdrew 's comment in the other PR had everything right, so:
@bcoe @nexdrew @stevemao does this clear this stuff up finally? That should be a good push forward IMO. Also, @nexdrew to answer your question of what blocks Windows usage: Nothing! 😊 I'm using this package daily on Windows. |
|
Closed #57 and renamed this to reflect the fact that, at least IMO, this is the best place to track the Appveyor CI issues for now. |
Opened PRs for appveyor config on conventional-changelog-core and git-raw-commits. Also opened windows fix PR in git-raw-commits: conventional-changelog-archived-repos/git-raw-commits#10. It's the most logical place, since it will actually fix all percent sign variable expansion problems by escaping them on windows. |
@Tapppi this agrees with what I was seeing, moving forward with fixes seems smart to me ... I don't think any of us want to spin up Windows VMs too frequently, having AppVeyor in place to stop regressions will be nice. |
So unfortunately my previous fix to |
All but node 0.10 work now, with https://ci.appveyor.com/project/Tapppi/standard-version/build/29 |
@Tapppi I'm pretty comfortable with removing |
Yeah I think that's the best move forwards. |
@Tapppi great work! |
Thanks @Tapppi! |
Ok, not sure how I managed to miss this before. Tests with mocked git don't work on windows due to
mock-git
and its depmock-bin
:mock-bin
creates an executable script with a shebang, which windows does not support, PR: (fix(windows): use windows path separator and cmd-shim stevemao/mock-bin#3)mock-git
doesn't escape slashes, PR: (fix: escape backslashes in originalGit path stevemao/mock-git#3)mock-git
has no version range in itsmock-bin
dependency thus not getting the windows fix when it lands, issue: (No version range in mock-bin dependency stevemao/mock-git#5)Both of these packages will need updates to make the mock tests work. I have created PRs in the respective repos and verified that standard-version tests are fixed with them. This issue is to track the progress of those fixes.
The text was updated successfully, but these errors were encountered: