-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't disallow fixup! messages #769
Comments
Just verified this. We fail to transfer the Analogous to commitlint/@commitlint/cli/src/cli.js Lines 158 to 160 in 6332d97
we should do the following: if (loaded.defaultIgnores) {
opts.defaultIgnores = loaded.defaultIgnores;
} Want to lend a hand? |
@ResDiaryLewis I see your pull request is merged. Is this issue still open? |
Hi @YegorZaremba, I'd probably consider the issue to be open until we can use the fix in a release |
I've just published |
defaultIgnores
doesn't seem to stop the commit messagefixup!
from bypassing rules:Example:
Expected Behavior
The message
fixup!
should fail in the same way asfoxup!
, as it breaks thesubject-empty
rule anddefaultIgnores
has been set tofalse
.Current Behavior
The message
fixup!
ignores thesubject-empty
rule.Affected packages
Steps to Reproduce (for bugs)
commitlint.config.js
with a single rule to disallow the messagefixup!
and setdefaultIgnores: false
(see above)echo "fixup!" | commitlint
or any other message beginning withfixup!
commitlint.config.js
```js module.exports = { defaultIgnores: false, rules: { 'subject-empty': [2, 'never'] } }; ```Context
I want to disallow fixups from being merged into my main branch.
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: