Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to need help link #540

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

mike-north
Copy link
Contributor

Description

Ensure that the "need help?" URL is clickable in terminals that auto-linkify when possible

Motivation and Context

In #518 the following message was added to commitlint log messages

(Need help? -> https://github.com/marionebl/commitlint#what-is-commitlint)

Because ) is a legal character in URLs, it ends up being picked up by link-aware editors (i.e., vscode) as a broken link:

https://github.com/marionebl/commitlint#what-is-commitlint)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Hey @mike-north , thanks for your PR. Please adjust the failing test with the added space. When that's done I'll merge this in. Thanks!

@escapedcat escapedcat merged commit fa6168a into conventional-changelog:master Jan 24, 2019
@escapedcat
Copy link
Member

@mike-north thx a lot. Sorry it took a bit longer.

@byCedric
Copy link
Member

This has been released in 7.4.0, hope it works fine for you now 😄 If it doesn't please let us know in a new issue! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants