-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No warning is given if commitlint.config.js does not exist #517
Comments
Cool. Didn't see it. Any idea when it will be merged? |
It's merged but not yet released. Not sure when the new release will come. |
Great. I will be on the lookout for it :-) |
We are in the process of distributing maintenance of commitlint between @escapedcat, @byCedric and me. I am a bit swamped with work recently so this drags out a bit. I am confident we'll do a feature release in the first two weeks of 2019 though 🤖 |
This has been released in the 7.3.0 range 🎉 |
Expected Behavior
If the
commitlint.config.js
file does not exist thencommitlint
does not have rules to check against and does nothing. It should display a warning message, e.g. "Warning: configuration not found, exiting".Current Behavior
When the
commitlint.config.js
file does not exist thencommitlint
does nothing, but also does not warn the user.Affected packages
Possible Solution
Check if the configuration with ruleset is available, if not then display a warning message, e.g. "Warning: configuration not found, exiting".
Steps to Reproduce (for bugs)
N/A
Context
It has happened two me twice know that I installed everything and forgot to create the config file and only discovered my omission later. In one case it meant a lot of wrong commit messages :-(
Your Environment
N/A
The text was updated successfully, but these errors were encountered: