Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong regexp #417

Closed
ValorLin opened this issue Aug 23, 2018 · 1 comment · Fixed by #439
Closed

Wrong regexp #417

ValorLin opened this issue Aug 23, 2018 · 1 comment · Fixed by #439
Labels
bug help wanted

Comments

@ValorLin
Copy link

ValorLin commented Aug 23, 2018 •
edited
Loading

https://github.com/marionebl/commitlint/blob/031ab00c06c5069748b61996cc9411b12a12ca73/%40commitlint/is-ignored/src/index.js#L6

image
It should be false.

Original Regexp

^(Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?))(?:\r?\n)*$)

image

Correct Regexp

^((Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?)))(?:\r?\n)*$)

image
@marionebl
Copy link
Contributor

Thanks for reporting. Would you mind submitting a PR to fix this?

@byCedric byCedric mentioned this issue Sep 10, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(is-ignored): use grouped regex to ignore merge commits
2 participants
@ValorLin @marionebl