-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cosmiconfig-typescript-loader v5 is not supported on node14 #3641
Comments
Thanks for the issue! |
Should be fixed in this new release: https://github.com/conventional-changelog/commitlint/releases/tag/v17.7.1 |
Sure, sorry about that. I saw the breaking change in their docs, but was a little too reliant on the test matrix 😅 and thought a feature bump was enough. I think node 14 is already in EOL, would it make sense to move to v18 in that case or is there a specific cadence for major releases? |
:D No worries, same here. Not sure if the test could be adjusted to catch something like this. Or if it's not worth the effort.
In the case of node versions we usually do a mayor release if a version is EOL. So ditching v14 would be the next step. We usually keep support for the maintenance version (v16 in this case). Would prepare this during the next days. Closing this issue for now then. |
Expected Behavior
Documentation says that node14 is currently supported, however this commit cosmiconfig-typescript-loader adds cosmiconfig-typescript-loader v5 which is not supported on node14 and throws an error when trying to install.
Due to the semver caret being used, this breaks multiple commitlint packages using 17.x.x including commitlint/load and commitlint/cli
Current Behavior
Cannot install on node14
Affected packages
Possible Solution
No response
Steps to Reproduce
Context
No response
commitlint --version
@commitlint/[email protected]
git --version
git version 2.39.2 (Apple Git-143)
node --version
v14.20.0
The text was updated successfully, but these errors were encountered: