Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmiconfig-typescript-loader v5 is not supported on node14 #3641

Closed
1 of 4 tasks
ImDevinC opened this issue Aug 10, 2023 · 4 comments
Closed
1 of 4 tasks

fix: cosmiconfig-typescript-loader v5 is not supported on node14 #3641

ImDevinC opened this issue Aug 10, 2023 · 4 comments
Assignees
Labels

Comments

@ImDevinC
Copy link

Expected Behavior

Documentation says that node14 is currently supported, however this commit cosmiconfig-typescript-loader adds cosmiconfig-typescript-loader v5 which is not supported on node14 and throws an error when trying to install.

Due to the semver caret being used, this breaks multiple commitlint packages using 17.x.x including commitlint/load and commitlint/cli

Current Behavior

Cannot install on node14

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Steps to Reproduce

1. npm install @commitlint/cli

Context

No response

commitlint --version

@commitlint/[email protected]

git --version

git version 2.39.2 (Apple Git-143)

node --version

v14.20.0

@ImDevinC ImDevinC added the bug label Aug 10, 2023
@escapedcat
Copy link
Member

escapedcat commented Aug 10, 2023

Thanks for the issue!
Pity the tests didn't catch this one. I guess we'll roll this back and keep this for the next major-version then.
wdyt @joberstein ?

@escapedcat escapedcat self-assigned this Aug 10, 2023
@escapedcat
Copy link
Member

@joberstein
Copy link
Contributor

Thanks for the issue! Pity the tests didn't catch this one. I guess we'll roll this back and keep this for the next major-version then. wdyt @joberstein ?

Sure, sorry about that. I saw the breaking change in their docs, but was a little too reliant on the test matrix 😅 and thought a feature bump was enough. I think node 14 is already in EOL, would it make sense to move to v18 in that case or is there a specific cadence for major releases?

@escapedcat
Copy link
Member

Sure, sorry about that. I saw the breaking change in their docs, but was a little too reliant on the test matrix 😅

:D No worries, same here. Not sure if the test could be adjusted to catch something like this. Or if it's not worth the effort.

I think node 14 is already in EOL, would it make sense to move to v18 in that case or is there a specific cadence for major releases?

In the case of node versions we usually do a mayor release if a version is EOL. So ditching v14 would be the next step. We usually keep support for the maintenance version (v16 in this case). Would prepare this during the next days.

Closing this issue for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants