Without lodash #37
Without lodash #37
Conversation
…tible with old react versions so we focus on the latest react
| }, | ||
| "peerDependencies": { | ||
| "react": "^0.12.0 || ^0.13.0 || ^0.14.0" | ||
| "react": "^0.14.0" |
There was a problem hiding this comment.
The sample code React.renderComponent doesn't work with 0.14. Since 0.14 has been out for 3 months, I thoughts it's most pragmatic to drop these old versions.
There was a problem hiding this comment.
Creating sample code that works with all versions would just confuse more than being helpful.
There was a problem hiding this comment.
@pekeler The sample code is for the latest version, but that doesn't mean you have to drop support for old versions and break people's existing installs
There was a problem hiding this comment.
Somebody with react 0.12 might try the sample and conclude that everything's broken. I'd increase the version of react-responsive instead. I'll make a another PW if you prefer the old way.
| @@ -5,7 +5,9 @@ | |||
| <link rel='stylesheet' type='text/css' href='sample.css'> | |||
| </head> | |||
| <body> | |||
| If you see this then something is wrong. | |||
| <div id="main"> | |||
| If you see this then something is wrongly. | |||
There was a problem hiding this comment.
can you fix this in this PR? otherwise when I merge this it's going to end up in the file
|
better? |
|
Published as 1.1.0 - thanks |
replaced lodash.omit with own implementation to reduce total file size