Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we hide ComPtr from the public API? #79

Closed
Boddlnagg opened this issue May 23, 2019 · 5 comments · Fixed by #80
Closed

Can we hide ComPtr from the public API? #79

Boddlnagg opened this issue May 23, 2019 · 5 comments · Fixed by #80

Comments

@Boddlnagg
Copy link
Collaborator

This would mean that publicly visible types such as IInspectable would refer to what's currently ComPtr<IInspectable>. Where we currently have references &IInspectable, we would then have effectively &ComPtr<IInspectable>, I don't know if that's a problem. The ABI representation is the same.
@Boddlnagg
Copy link
Collaborator Author

I have been doing some rather successful experiments in a branch: https://github.com/Boddlnagg/winrt-rust/tree/cleanup

@contextfree
Copy link
Owner

What's left to do to get that branch ready to be merged? Can you use any help?

@Boddlnagg
Copy link
Collaborator Author

The "problem" is that it's based on the 2018 edition branch (see #74) and I wanted to make a release with some other changes before merging that.

@Boddlnagg Boddlnagg mentioned this issue Jun 10, 2019
Merged
@Boddlnagg
Copy link
Collaborator Author

Boddlnagg commented Jun 10, 2019 •
edited
Loading

So I did release 0.6.0, merged the 2018 edition change, rebased this branch and opened a PR for it: #80

@contextfree
Copy link
Owner

Sweet, thanks! I'm trying this out on a Windows.UI.Composition sample I've been working on in case you want more testing/validation, though don't mean to suggest you should hold up merging whenever you think it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide ComPtr from public API Boddlnagg/winrt-rust
2 participants
@contextfree @Boddlnagg