feat: detect URL change [TOL-1059] #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesRijckaert
changed the title
aodhagan-cf
reviewed
Apr 12, 2023
src/types.ts
Outdated
| @@ -33,18 +33,32 @@ type IframeConnectedMessage = { | |||
| action: 'IFRAME_CONNECTED'; | |||
| connected: true; | |||
| tags: number; | |||
| url: string; | |||
There was a problem hiding this comment.
I don't feel super strongly but as a suggestion, maybe this could be root or anchorUrl for clarity?
aodhagan-cf
reviewed
Apr 12, 2023
src/tests/pollUrlChanges.spec.ts
Outdated
aodhagan-cf
approved these changes
Apr 12, 2023
chrishelgert
force-pushed
the
feat/detect-url-change
branch
from
1f4ecc8 to
8a6e9ea
Compare
chrishelgert
approved these changes
Apr 17, 2023
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting URL changes with a polling approach (interval) since
hashchangeandpopstateevents were not working with our next js starter template.